On Wed, 27 Mar 2013 00:44:59 +0100 Daniel Vetter <daniel.vetter at ffwll.ch> wrote: > The old code only handled either 6bpc or 8bpc. Since it's easy to do, > reorganize the code to be a bit more generic so that it can also handle > 10bpc and 12bpc. Note that we still start with 8bpc, so there's no > functional change. > > Also, since we no don't need to compute the 6BPC flag in the mode_valid > callback, we can consolidate things a bit. That requires though that > the link bw computation is moved up in the compute_config callback. > > Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch> > --- > drivers/gpu/drm/i915/intel_display.c | 4 -- > drivers/gpu/drm/i915/intel_dp.c | 103 ++++++++++++++++------------------- > drivers/gpu/drm/i915/intel_drv.h | 3 - > 3 files changed, 47 insertions(+), 63 deletions(-) > I had a harder time following this one (DP is just complex), but it looks ok so far. I'll feel better with lots of testing. Reviewed-by: Jesse Barnes <jbarnes at virtuousgeek.org> -- Jesse Barnes, Intel Open Source Technology Center