On Wed, Mar 27, 2013 at 6:06 PM, Jesse Barnes <jbarnes at virtuousgeek.org> wrote: > + if (HAS_PCH_SPLIT(dev) && !HAS_DDI(dev) && !is_cpu_edp(intel_dp)) > + pipe_config->has_pch_encoder = true; > + > > This could just do > if (intel_dp->is_pch_edp) > pipe_config->has_pch_encoder = true; > right? Since we cover the other cases in dp_init_connector? That would give you two wrong case currently: - hsw port D eDP would be marked as pch port - any pch non-eDP DP ports would not be marked as pch ports The ugly thing with this patch here is that this property is actually fixed to the encoder, but I dynamically compute it in compute_config. We have a few other such cases (e.g. the cpu transcoder for edp on hsw). But I've figured there's no point in adding something clever, which then updates the pipe_config according to connected encoders with data structures ... -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch
