== Series Details == Series: drm/i915: refactor KBL/TGL/ADLS stepping scheme (rev2) URL : https://patchwork.freedesktop.org/series/87323/ State : warning == Summary == $ dim checkpatch origin/drm-tip c52f0ea75128 drm/i915: remove unused ADLS_REVID_* macros 1d23fa9cb274 drm/i915: split out stepping info to a new file -:123: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #123: new file mode 100644 total: 0 errors, 1 warnings, 0 checks, 162 lines checked 93d71ad11f06 drm/i915: add new helpers for accessing stepping info -:30: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i915' - possible side-effects? #30: FILE: drivers/gpu/drm/i915/i915_drv.h:1280: +#define IS_DISPLAY_STEP(__i915, since, until) \ + (drm_WARN_ON(&(__i915)->drm, INTEL_DISPLAY_STEP(__i915) == STEP_NONE), \ + INTEL_DISPLAY_STEP(__i915) >= (since) && INTEL_DISPLAY_STEP(__i915) <= (until)) -:34: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i915' - possible side-effects? #34: FILE: drivers/gpu/drm/i915/i915_drv.h:1284: +#define IS_GT_STEP(__i915, since, until) \ + (drm_WARN_ON(&(__i915)->drm, INTEL_GT_STEP(__i915) == STEP_NONE), \ + INTEL_GT_STEP(__i915) >= (since) && INTEL_GT_STEP(__i915) <= (until)) total: 0 errors, 0 warnings, 2 checks, 70 lines checked c5a4a8ab6645 drm/i915: switch KBL to the new stepping scheme -:108: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev_priv' - possible side-effects? #108: FILE: drivers/gpu/drm/i915/i915_drv.h:1478: +#define IS_KBL_GT_STEP(dev_priv, since, until) \ + (IS_KABYLAKE(dev_priv) && IS_GT_STEP(dev_priv, since, until)) -:110: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev_priv' - possible side-effects? #110: FILE: drivers/gpu/drm/i915/i915_drv.h:1480: +#define IS_KBL_DISPLAY_STEP(dev_priv, since, until) \ + (IS_KABYLAKE(dev_priv) && IS_DISPLAY_STEP(dev_priv, since, until)) -:151: CHECK:LINE_SPACING: Please don't use multiple blank lines #151: FILE: drivers/gpu/drm/i915/intel_step.c:16: + total: 0 errors, 0 warnings, 3 checks, 198 lines checked 3ab291f069dc drm/i915: switch TGL and ADL to the new stepping scheme -:54: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i915' - possible side-effects? #54: FILE: drivers/gpu/drm/i915/i915_drv.h:1513: +#define IS_TGL_DISP_STEPPING(__i915, since, until) \ + (IS_TIGERLAKE(__i915) && \ + IS_DISPLAY_STEP(__i915, since, until)) -:62: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i915' - possible side-effects? #62: FILE: drivers/gpu/drm/i915/i915_drv.h:1517: +#define IS_TGL_UY_GT_STEPPING(__i915, since, until) \ + ((IS_TGL_U(__i915) || IS_TGL_Y(__i915)) && \ + IS_GT_STEP(__i915, since, until)) -:71: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i915' - possible side-effects? #71: FILE: drivers/gpu/drm/i915/i915_drv.h:1521: +#define IS_TGL_GT_STEPPING(__i915, since, until) \ + (IS_TIGERLAKE(__i915) && !(IS_TGL_U(__i915) || IS_TGL_Y(__i915)) && \ + IS_GT_STEP(__i915, since, until)) -:85: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i915' - possible side-effects? #85: FILE: drivers/gpu/drm/i915/i915_drv.h:1538: +#define IS_ADLS_DISP_STEPPING(__i915, since, until) \ + (IS_ALDERLAKE_S(__i915) && \ + IS_DISPLAY_STEP(__i915, since, until)) -:93: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i915' - possible side-effects? #93: FILE: drivers/gpu/drm/i915/i915_drv.h:1542: +#define IS_ADLS_GT_STEPPING(__i915, since, until) \ + (IS_ALDERLAKE_S(__i915) && \ + IS_GT_STEP(__i915, since, until)) total: 0 errors, 0 warnings, 5 checks, 127 lines checked f94a68bcd095 drm/i915: rename DISP_STEPPING->DISPLAY_STEP and GT_STEPPING->GT_STEP -:113: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i915' - possible side-effects? #113: FILE: drivers/gpu/drm/i915/i915_drv.h:1513: +#define IS_TGL_DISPLAY_STEP(__i915, since, until) \ (IS_TIGERLAKE(__i915) && \ IS_DISPLAY_STEP(__i915, since, until)) -:118: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i915' - possible side-effects? #118: FILE: drivers/gpu/drm/i915/i915_drv.h:1517: +#define IS_TGL_UY_GT_STEP(__i915, since, until) \ ((IS_TGL_U(__i915) || IS_TGL_Y(__i915)) && \ IS_GT_STEP(__i915, since, until)) -:123: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i915' - possible side-effects? #123: FILE: drivers/gpu/drm/i915/i915_drv.h:1521: +#define IS_TGL_GT_STEP(__i915, since, until) \ (IS_TIGERLAKE(__i915) && !(IS_TGL_U(__i915) || IS_TGL_Y(__i915)) && \ IS_GT_STEP(__i915, since, until)) -:132: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i915' - possible side-effects? #132: FILE: drivers/gpu/drm/i915/i915_drv.h:1538: +#define IS_ADLS_DISPLAY_STEP(__i915, since, until) \ (IS_ALDERLAKE_S(__i915) && \ IS_DISPLAY_STEP(__i915, since, until)) -:137: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i915' - possible side-effects? #137: FILE: drivers/gpu/drm/i915/i915_drv.h:1542: +#define IS_ADLS_GT_STEP(__i915, since, until) \ (IS_ALDERLAKE_S(__i915) && \ IS_GT_STEP(__i915, since, until)) total: 0 errors, 0 warnings, 5 checks, 117 lines checked 19a6fa288b97 drm/i915: rename disp_stepping->display_step and gt_stepping->gt_step d1a2f1d5bb5c drm/i915: rename i915_rev_steppings->intel_step_info _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
