On Wed, 27 Mar 2013 00:44:51 +0100 Daniel Vetter <daniel.vetter at ffwll.ch> wrote: > To make decent modeset state checking possible (e.g. for the check > mode with atomic modesetting) we want to have the full pipe > configuration and state checks done before we touch the hw. > > To ensure that all the little bits&pieces that are now moved to the > pipe_config handle this correctly, move its computation to the right > spot now, before we touch the hw in the disable_pipes step. > > Reviewed-by: Paulo Zanoni <paulo.r.zanoni at intel.com> > Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch> > --- > drivers/gpu/drm/i915/intel_display.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c > index 34986fe..56ff8a5 100644 > --- a/drivers/gpu/drm/i915/intel_display.c > +++ b/drivers/gpu/drm/i915/intel_display.c > @@ -7829,12 +7829,6 @@ int intel_set_mode(struct drm_crtc *crtc, > intel_modeset_affected_pipes(crtc, &modeset_pipes, > &prepare_pipes, &disable_pipes); > > - DRM_DEBUG_KMS("set mode pipe masks: modeset: %x, prepare: %x, disable: %x\n", > - modeset_pipes, prepare_pipes, disable_pipes); > - > - for_each_intel_crtc_masked(dev, disable_pipes, intel_crtc) > - intel_crtc_disable(&intel_crtc->base); > - > *saved_hwmode = crtc->hwmode; > *saved_mode = crtc->mode; > > @@ -7853,6 +7847,12 @@ int intel_set_mode(struct drm_crtc *crtc, > } > } > > + DRM_DEBUG_KMS("set mode pipe masks: modeset: %x, prepare: %x, disable: %x\n", > + modeset_pipes, prepare_pipes, disable_pipes); > + > + for_each_intel_crtc_masked(dev, disable_pipes, intel_crtc) > + intel_crtc_disable(&intel_crtc->base); > + > for_each_intel_crtc_masked(dev, prepare_pipes, intel_crtc) { > if (intel_crtc->base.enabled) > dev_priv->display.crtc_disable(&intel_crtc->base); Looks safe :) Reviewed-by: Jesse Barnes <jbarnes at virtuousgeek.org> -- Jesse Barnes, Intel Open Source Technology Center