On Thu, 10 Jan 2013 10:02:42 -0500 Egbert Eich <eich at suse.de> wrote: > + if (hotplug_trigger & intel_connector->hpd_status_bit) { > + if (jiffies > (intel_connector->last_hpd_jiffies + msecs_to_jiffies(1000)) || > + jiffies < intel_connector->last_hpd_jiffies) { Can you use time_after() here instead? Otherwise this looks really nice. We should get it lots of testing and soak time. Reviewed-by: Jesse Barnes <jbarnes at virtuousgeek.org> -- Jesse Barnes, Intel Open Source Technology Center