On Thu, 10 Jan 2013 10:02:40 -0500
Egbert Eich <eich at suse.de> wrote:
> So far the hotplug_supported_mask in the struct drm_i915_private
> is only used for pre-Ironlake chipsets.
> This patch sets up the correct value for all generations.
>
> Signed-off-by: Egbert Eich <eich at suse.de>
> ---
> drivers/gpu/drm/i915/i915_drv.h | 4 ++
> drivers/gpu/drm/i915/i915_irq.c | 71 +++++++++++++++++++++++++++++++++++++
> drivers/gpu/drm/i915/intel_crt.c | 2 +-
> drivers/gpu/drm/i915/intel_dp.c | 4 +--
> drivers/gpu/drm/i915/intel_hdmi.c | 4 +--
> drivers/gpu/drm/i915/intel_sdvo.c | 12 +------
> 6 files changed, 79 insertions(+), 18 deletions(-)
I like it.
Reviewed-by: Jesse Barnes <jbarnes at virtuousgeek.org>
Just a tiny style nitpick. I'd prefer:
+ /* SDVO is treated separately */
+ if (IS_IVYBRIDGE(dev) ||
+ IS_HASWELL(dev) ||
+ (HAS_PCH_SPLIT(dev) && HAS_PCH_CPT(dev))) {
to be
+ /* SDVO is treated separately */
+ if (IS_IVYBRIDGE(dev) || IS_HASWELL(dev) ||
+ (HAS_PCH_SPLIT(dev) && HAS_PCH_CPT(dev))) {
instead because vertical space is precious. But that's definitely not
worth delaying this patch over.
--
Jesse Barnes, Intel Open Source Technology Center
