On Wed, Mar 20, 2013 at 09:40:04AM +0100, Maarten Lankhorst wrote: > Is the drmSetInterfaceVersion call really needed here? If I look at DRM_IOCTL_GET_UNIQUE, > I don't see any requirement of drm master or anything, so it looks to me like for this specific race > the drmSetInterfaceVersion call can be skipped entirely without any side effects. > This would end up with cleaner code here, and drop the master requirement entirely. Indeed, it does look like drmSetVersion() at that point is overkill. Instead we will hit the race later in the drivers. For the purposes of clearer code, we could happily lose that drmSetVersion(). > Of course there's still a race that needs to be investigated, and is currently not completely understood, I think. We are all in agreement. Ultimately we want to root cause the race, in the meantime we need a fallback to make sure that no desktop is left behind! -Chris -- Chris Wilson, Intel Open Source Technology Centre
