On Tue, 19 Mar 2013 09:42:56 +0100 Daniel Vetter <daniel at ffwll.ch> wrote: > > --- a/include/uapi/drm/i915_drm.h > > +++ b/include/uapi/drm/i915_drm.h > > @@ -949,6 +949,7 @@ struct drm_intel_overlay_attrs { > > #define I915_SET_COLORKEY_NONE (1<<0) /* disable color key matching */ > > #define I915_SET_COLORKEY_DESTINATION (1<<1) > > #define I915_SET_COLORKEY_SOURCE (1<<2) > > +#define I915_SET_COLORKEY_ALPHA (1<<3) > > We've added this driver-private ioctl before attributes everywhere was > possible. I think we need to convert that before adding more stuff ... > > Also some discussion on dri-devel about a somewhat standardized set of > plane blending properties can't hurt. > > Yes, I know that this will lead to a massive dri-devel bikeshed ;-) Yeah we need some properties for this to fit in with the atomic bits. This patch actually pre-dates that by a bit (it's very old)... I'm sure Ville has ideas on what he'd like to see. -- Jesse Barnes, Intel Open Source Technology Center