Hi Damien, thanks a lot for the review. On Mon, Mar 18, 2013 at 04:04:42PM +0000, Damien Lespiau wrote: > A quick review trying to use the tool: > > * I think it'd be better if byte 0 is at the right, it seems to be the > usual ways to represent registers, lower bits at the right. > * there's a bug when giving advanced=1 on the URL, the tool doesn't > seem to take it into account > * it'd be nice to get rid of the trailing white space (no review would > be complete without a mention to trailing white space, rule #1 of > the open source world) from the imported js files, I usually use a > script around: > sed -i -e 's,[ \t]*$,,' $file I've pushed a branch to GitHub which implements these improvements, and can be used for temporary work-in-progress before squashing and resubmitting: git://github.com/ChrisCummins/intel-gpu-tools.git wip/gen_regions Regards, Chris
