On Wed, Mar 06, 2013 at 08:03:19PM -0300, Paulo Zanoni wrote:
> From: Paulo Zanoni <paulo.r.zanoni at intel.com>
>
> Now it returns false for all platforms unless they're explicitly
> listed on the function. There should be no real difference, except for
> the fact that it now returns false on Haswell.
>
> Signed-off-by: Paulo Zanoni <paulo.r.zanoni at intel.com>
I wouldn't mind comments in the commit or code reminding me that IBX and
CPT cover ILk->IVB, and gm45 counts as gen4, but that's just 'cause I
have a bad memory.
Reviewed-by: Ben Widawsky <ben at bwidawsk.net>
> ---
> drivers/gpu/drm/i915/intel_lvds.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_lvds.c b/drivers/gpu/drm/i915/intel_lvds.c
> index 6b24fc5..53bd5fd 100644
> --- a/drivers/gpu/drm/i915/intel_lvds.c
> +++ b/drivers/gpu/drm/i915/intel_lvds.c
> @@ -1020,15 +1020,15 @@ static bool intel_lvds_supported(struct drm_device *dev)
> {
> /* With the introduction of the PCH we gained a dedicated
> * LVDS presence pin, use it. */
> - if (HAS_PCH_SPLIT(dev))
> + if (HAS_PCH_IBX(dev) || HAS_PCH_CPT(dev))
> return true;
>
> - if (IS_VALLEYVIEW(dev))
> - return false;
> -
> /* Otherwise LVDS was only attached to mobile products,
> * except for the inglorious 830gm */
> - return IS_MOBILE(dev) && !IS_I830(dev);
> + if (INTEL_INFO(dev)->gen <= 4 && IS_MOBILE(dev) && !IS_I830(dev))
> + return true;
> +
> + return false;
> }
--
Ben Widawsky, Intel Open Source Technology Center
