Clean up intel_dp.c pre-emptively before Dave gets here. ;) Split out pps and aux code to intel_pps.[ch] and intel_dp_aux.[ch], respectively. This reduces intel_dp.c size by 2k lines: - 8370 drivers/gpu/drm/i915/display/intel_dp.c + 6313 drivers/gpu/drm/i915/display/intel_dp.c The pps code is pretty messy, so I've first done almost pure code movement, and added interface cleanups on top in smaller bits for easier review. The patches can be squashed together, but I figured it's easier this way. There's still room for improvement, but it's a good start to move the code to a separate file. BR, Jani. Jani Nikula (13): drm/i915/pps: abstract panel power sequencer from intel_dp.c drm/i915/pps: rename pps_{,un}lock -> intel_pps_{,un}lock drm/i915/pps: rename intel_edp_backlight_* to intel_pps_backlight_* drm/i915/pps: rename intel_edp_panel_* to intel_pps_* drm/i915/pps: rename edp_panel_* to intel_pps_*_unlocked drm/i915/pps: abstract intel_pps_vdd_off_sync drm/i915/pps: add higher level intel_pps_init() call drm/i915/pps: abstract intel_pps_reinit() drm/i915/pps: rename intel_dp_check_edp to intel_pps_check_power_unlocked drm/i915/pps: rename intel_power_sequencer_reset to intel_pps_reset_all drm/i915/pps: add locked intel_pps_wait_power_cycle drm/i915/pps: rename vlv_init_panel_power_sequencer to vlv_pps_init drm/i915/dp: split out aux functionality to intel_dp_aux.c drivers/gpu/drm/i915/Makefile | 2 + drivers/gpu/drm/i915/display/intel_ddi.c | 9 +- .../drm/i915/display/intel_display_power.c | 6 +- drivers/gpu/drm/i915/display/intel_dp.c | 2235 +---------------- drivers/gpu/drm/i915/display/intel_dp.h | 5 +- drivers/gpu/drm/i915/display/intel_dp_aux.c | 683 +++++ drivers/gpu/drm/i915/display/intel_dp_aux.h | 18 + drivers/gpu/drm/i915/display/intel_pps.c | 1393 ++++++++++ drivers/gpu/drm/i915/display/intel_pps.h | 49 + 9 files changed, 2243 insertions(+), 2157 deletions(-) create mode 100644 drivers/gpu/drm/i915/display/intel_dp_aux.c create mode 100644 drivers/gpu/drm/i915/display/intel_dp_aux.h create mode 100644 drivers/gpu/drm/i915/display/intel_pps.c create mode 100644 drivers/gpu/drm/i915/display/intel_pps.h -- 2.20.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx