On Fri, 08 Mar 2013 15:51:44 +0200 Jani Nikula <jani.nikula at linux.intel.com> wrote: > > + } else { > > + pp_control_reg = PP_CONTROL; > > + pp_on_reg = PP_ON_DELAYS; > > + pp_off_reg = PP_OFF_DELAYS; > > + pp_div_reg = PP_DIVISOR; > > + } > > Is this else branch needed? ironlake_get_pp_control() does not support > pre-pch split hw either. Does pre-pch split hw support edp? > No it isn't. When I first looked at it I thought "what about G4x" but then later realized that G4x only supports external DP, not embedded. So I'll drop these hunks. Thanks, -- Jesse Barnes, Intel Open Source Technology Center