Am Montag, den 04.03.2013, 17:17 +0100 schrieb Daniel Vetter: > On Mon, Mar 04, 2013 at 09:24:38AM -0500, Egbert Eich wrote: > > On G45 some low res modes (800x600 and 1024x768) produce a blank > > screen when the display plane is enabled with with cursor plane > > off. > > Experiments showed that this issue occurred when the following > > conditions were met: > > a. a previous mode had the cursor plane enabled (Xserver). > > b. this mode or the previous one was using self refresh. (Thus > > the problem was only seen with low res modes). > > The screens lit up as soon as the cursor plane got enabled. > > Therefore the blank screen occurred only in console mode, not > > when running an Xserver. > > It also seemed to be necessary to disable self refresh while briefly > > enabling the cursor plane. > > > > Signed-off-by: Egbert Eich <eich at suse.com> > > Bugzilla: https://bugs.freedesktop.org/attachment.cgi?bugid=61457 > > Acked-by: Chris Wilson <chris at chris-wilson.co.uk> > > This w/a is impressive ;-) Applied to -fixes, thanks for the patch. > -Daniel > > > --- > > drivers/gpu/drm/i915/intel_display.c | 28 +++++++++++++++++++++++++++- > > 1 files changed, 27 insertions(+), 1 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c > > index 6eb3882..689cc3a 100644 > > --- a/drivers/gpu/drm/i915/intel_display.c > > +++ b/drivers/gpu/drm/i915/intel_display.c [?] > > @@ -6337,7 +6363,7 @@ static int intel_crtc_cursor_set(struct drm_crtc *crtc, > > i915_gem_detach_phys_object(dev, intel_crtc->cursor_bo); > > } else > > i915_gem_object_unpin(intel_crtc->cursor_bo); > > - drm_gem_object_unreference(&intel_crtc->cursor_bo->base); > > + drm_gem_object_unreference(&intel_crtc->cursor_bo->base); As there are no {} around the else branch, this indentation is incorrect, right? > > } > > > > mutex_unlock(&dev->struct_mutex); Thanks, Paul -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 198 bytes Desc: This is a digitally signed message part URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20130306/0e5ab954/attachment-0001.pgp>
