On Fri, Mar 1, 2013 at 11:08 PM, Jesse Barnes <jbarnes at virtuousgeek.org> wrote: > From: Pallavi G <pallavi.g at intel.com> > > > For high res modes m n p calculation is fixed for VLV platform. > > Signed-off-by: Vijay Purushothaman <vijay.a.purushothaman at intel.com> > Signed-off-by: Pallavi G <pallavi.g at intel.com> > Signed-off-by: Yogesh M <yogesh.mohan.marimuthu at intel.com> > Signed-off-by: Gajanan Bhat <gajanan.bhat at intel.com> I'll throw a few more nits on top: - From: should usually also be the first sob line or maybe a quick comment about the origins of the patch. - This function indents a few too many levels by any standard. - I'd prefer if we switch dp to just select the desired m/n/p values for a given clock like on all other platforms. See the vlv FIXME in https://patchwork.kernel.org/patch/2173841/ Cheers, Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch
