On Tue, Feb 12, 2013 at 07:06:59PM +0200, Jani Nikula wrote: > Keep all the platform output selection in intel_output_setup(), and don't > scatter it around. I see this as doing the opposite. You are littering an already over complicated routine with LVDS specific information. > As a useful side effect, do not try to enable LVDS on > HSW or VLV. But you wouldn't with the old arrangement either. > Some checks are done in a slightly different order than before, and on some > platforms VGA is now initialized before LVDS. Is that significant? You have not sold me on the benefits of this change. -Chris -- Chris Wilson, Intel Open Source Technology Centre