[PATCH] Build: Add --disable-tests configure flag to avoid tests build.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Apparently Cairo wasn't the main reason, beucase something at /libs
depends on Cairo as well. So cairo dependencie wasn't removed from
checks.
But now on, when including any dependencies used only for tests please
add pkg_check_modules only if tests build enalbed.


On Thu, Feb 7, 2013 at 8:40 PM, Ben Widawsky <ben at bwidawsk.net> wrote:
> On Thu, Feb 07, 2013 at 09:52:32PM +0000, Damien Lespiau wrote:
>> On Mon, Feb 04, 2013 at 07:52:27PM -0200, Rodrigo Vivi wrote:
>> > Tests are still being built by default. However this request
>> > came from OSVs in order to allow them to include i-g-t in their
>> > distributions by default avoiding adding more and more dependencies
>> > since we are improving and adding more and more tests.
>>
>> Sorry to be the party crasher here, but the patch doesn't seem to really
>> remove dependencies because the default action-if-not-found of
>> PKG_CHECK_MODULES will end the configure script. For instance
>>
>> PKG_CHECK_MODULES(CAIRO, [cairo])
>>
>> will end the configure script if cairo is not found.
>>
>> What are the goals here? remove dependencies? which ones?
>>
>> Hopefully not too wrong with that stupid FOSDEM flu :)
>>
>> --
>> Damien
>
> Takashi asked for it, and reviewed it, so
> http://en.wikipedia.org/wiki/Ostrich_algorithm?
>
> --
> Ben Widawsky, Intel Open Source Technology Center



--
Rodrigo Vivi
Blog: http://blog.vivi.eng.br


[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux