On Tue, Jan 29, 2013 at 01:55:46PM +0100, Daniel Vetter wrote: > On Fri, Jan 25, 2013 at 04:41:05PM -0800, Ben Widawsky wrote: > > This refactor clearly identifies the GEN specific portion of the aliased > > ppgtt code. Aside from some of the gen specific parts being extracted, > > it also preps us for an upcoming patch that pulls out the size, which > > has some nice benefits. > > > > v2: Fix wonky error handling (Chris) > > > > Signed-off-by: Ben Widawsky <ben at bwidawsk.net> > > Functionally we seem to have this patch already with > > commit e9ccfd7b94f1ca9b46b992a19d2e8c5af70e4c69 > Author: Daniel Vetter <daniel.vetter at ffwll.ch> > Date: Thu Jan 24 13:49:56 2013 -0800 > > drm/i915: extract hw ppgtt setup/cleanup code > > Yeah, you're allowed to hate me with the heat of a thousand suns now ;-) > -Daniel I already did. I guess when I rebased the series, you hadn't merged those yet. -- Ben Widawsky, Intel Open Source Technology Center