On Mon, Jan 28, 2013 at 7:26 PM, Ben Widawsky <ben at bwidawsk.net> wrote: > But as I said above, we really need to calculate how much PD space we > need. Each PD has PAGE_SIZE of space required > gtt_size >> 22 >> PAGE_SIZE = gtt_size >> 10 gtt_size >> 22 * PAGE_SIZE > In hindsight, maybe doing that calculation in the code would have been > better. > > Anyway, to answer the question, I think yes, it should match > ppgtt->num_pd_entries * PAGE_SIZE That looks much clearer imo and spells out what happens much better (we still a pte = full page in the address space for each ppgtt pd). Can you please apply this bikeshed to the patch? -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch
