From: Paulo Zanoni <paulo.r.zanoni at intel.com> Hi This is new version of 2 patches I sent last week. First we change how unclaimed registers are currently reported by our driver and in the end we enable gen 7 error interrupts. Here's what we do: - Make the current code a little bit more organized - Use FPGA_DBG instead of GEN7_ERR_INT for the polling code - Initialize FPGA_DBG to clear one "unclaimed register" message - Check unclaimed registers on I915_READ - Replace the DRM_ERROR with WARNs - Only print uncnlaimed registers if drm_debug is set - Finally, print Gen 7 error interrupts We had some discussion regarding these patches, and there is still no consensus on what exactly we should do, so feel free to nack patches. Still, the patches here are to some extent based on the comments I received (mainly from Ben, Daniel and Chris), so I hope they're not too bad. Also, I really think that at least the first 3 patches should be merged, and also some equivalent form of the last patch should be merged. Another thing I have to add: after patch 7 you may see a few dozen "unclaimed register" messages when booting if you have the power well disabled. All these messages go away if you blacklist snd_hda_intel. Still, I like to have messages reminding me that something is wrong in some driver. And you'll only see those messages if you have drm_debug, because of patch 0006. Thanks, Paulo Paulo Zanoni (7): drm/i915: create macros for the "unclaimed register" checks drm/i915: use FPGA_DBG for the "unclaimed register" checks drm/i915: clear the FPGA_DBG_RM_NOCLAIM bit at driver init drm/i915: check for unclaimed registers on I915_READ too drm/i915: WARN on unclaimed registers drm/i915: only check for unclaimed registers if drm_debug drm/i915: print Gen 7 error interrupts drivers/gpu/drm/i915/i915_dma.c | 4 ++++ drivers/gpu/drm/i915/i915_drv.c | 26 ++++++++++++++++++-------- drivers/gpu/drm/i915/i915_irq.c | 28 +++++++++++++++++++++++++++- drivers/gpu/drm/i915/i915_reg.h | 5 ++++- 4 files changed, 53 insertions(+), 10 deletions(-) -- 1.7.10.4
