Hi
2013/1/24 <ville.syrjala at linux.intel.com>:
> From: Ville Syrj?l? <ville.syrjala at linux.intel.com>
>
> Use intel_dig_port->port rather than intel_dp->output_reg.
>
> Signed-off-by: Ville Syrj?l? <ville.syrjala at linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_dp.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index f05364a..d274f8e 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -2293,16 +2293,17 @@ g4x_dp_detect(struct intel_dp *intel_dp)
> {
> struct drm_device *dev = intel_dp_to_dev(intel_dp);
> struct drm_i915_private *dev_priv = dev->dev_private;
> + struct intel_digital_port *intel_dig_port = dp_to_dig_port(intel_dp);
Minor optional detail:
With "struct drm_device *dev = intel_dig_port->base.base.dev" you
would save a call to intel_dp_to_dev (which calls dp_to_dig_port).
With or without that:
Reviewed-by: Paulo Zanoni <paulo.r.zanoni at intel.com>
> uint32_t bit;
>
> - switch (intel_dp->output_reg) {
> - case DP_B:
> + switch (intel_dig_port->port) {
> + case PORT_B:
> bit = DPB_HOTPLUG_LIVE_STATUS;
> break;
> - case DP_C:
> + case PORT_C:
> bit = DPC_HOTPLUG_LIVE_STATUS;
> break;
> - case DP_D:
> + case PORT_D:
> bit = DPD_HOTPLUG_LIVE_STATUS;
> break;
> default:
> --
> 1.7.12.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Paulo Zanoni
