[PATCH] drm/i915: re-add dropped dma_mask configuration

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jan 18, 2013 at 07:18:19PM -0800, Ben Widawsky wrote:
> I'm pretty sure without this, and with DMAR, things explode
> spectacularly. I got to this patch via bisecting broken i-g-t on my
> machine.
> 
> If I had wired ethernet, I would figure out exactly what's failing with
> netconsole. To be honest, nothing particularly stands out to me looking
> over the code as to why it should fail though.  If someone is more
> inquisitive than I, I would be interested to know why we actually need
> this bit of code. Not sure if things are broken without DMAR.
> 
> Daniel noticed this was accidentally dropped after I rebased my branch,
> but figured it wasn't really needed. Seems it is.
> 
> Given that my patch:
> commit 2ca466ae28f25e62090e4b57c90bcfee080a47a9
> Author: Ben Widawsky <ben at bwidawsk.net>
> Date:   Fri Jan 18 12:30:33 2013 -0800
> 
>     drm/i915: Needs_dmar, not
> 
> I'd suggest just squashing this into 2ca466ae28 since this was never
> intentional anyway.
> 
> Cc: Daniel Vetter <daniel.vetter at ffwll.ch>
> Signed-off-by: Ben Widawsky <ben at bwidawsk.net>
Queued for -next, thanks for the patch. I'll beat on things a beat and
then squash your patches around (and annoy our QA with an updated
-testing, since the old one's stale already).
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch


[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux