Quoting Andi Shyti (2020-03-31 18:13:09)
> Hi Chris,
>
> On Tue, Mar 31, 2020 at 05:53:32PM +0100, Chris Wilson wrote:
> > Quoting Andi Shyti (2020-03-31 17:45:08)
> > > +static void intel_sseu_copy_subslices(const struct sseu_dev_info *sseu,
> > > + int slice, u8 *to_mask)
> > > +{
> > > + int offset = slice * sseu->ss_stride;
> > > +
> > > + memcpy(&to_mask[offset], &sseu->subslice_mask[offset], sseu->ss_stride);
> > > +}
> >
> > Worth moving all the sseu into their file? There's quite a few of them
> > and each quite chunky.
> >
> > > +static int interrupt_info_show(struct seq_file *m, void *data)
> >
> > And if we start there, we might end up with debugfs_gt_irq.c as well?
> > (Not that I see any use for this debugfs info :)
>
> add a debufs_gt_sseu.c and debugfs_gt_irq.c, isn't it a bit
> excessive? I also do agree that everything in one file looks a
> bit stuffed.
I think debugfs_gt_sseu.c is reasonably justified. (There's also an rcs
topology apparently!) That's a good chunk of 250+ lines of code that no
one wants to ever to have to read.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
