On Wed, Sep 26, 2012 at 11:50:36AM -0400, Adam Jackson wrote: > On Wed, 2012-09-26 at 18:43 +0300, Jani Nikula wrote: > > The dithering introduced in > > > > commit 3b5c78a35cf7511c15e09a9b0ffab290a42d9bcf > > Author: Adam Jackson <ajax at redhat.com> > > Date: Tue Dec 13 15:41:00 2011 -0800 > > > > drm/i915/dp: Dither down to 6bpc if it makes the mode fit > > > > stores the INTEL_MODE_DP_FORCE_6BPC flag in the private_flags of the > > adjusted mode, while i9xx_crtc_mode_set() and ironlake_crtc_mode_set() use > > the original mode, without the flag, so it would never have any > > effect. However, the BPC was clamped by VBT settings, making things work by > > coincidence, until that part was removed in > > > > commit 4344b813f105a19f793f1fd93ad775b784648b95 > > Author: Daniel Vetter <daniel.vetter at ffwll.ch> > > Date: Fri Aug 10 11:10:20 2012 +0200 > > > > Use adjusted_mode instead of mode when checking for > > INTEL_MODE_DP_FORCE_6BPC to make the flag have effect. > > > > v2: Don't forget to fix this in i9xx_crtc_mode_set() also, pointed out by > > Daniel both before and after sending the first patch. > > Reviewed-by: Adam Jackson <ajax at redhat.com> Picked up for -fixes, thanks for the patch. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch
