On Mon, Sep 24, 2012 at 07:12:16PM -0300, Rodrigo Vivi wrote: > This was easy for me, feel free to use: > > Reviewed-by: Rodrigo Vivi <rodrigo.vivi at gmail.com> Already merged to dinq before I've seen your r-b, thanks anyway for the review (and the patch obviously too). I've bikeshedded the actual fix a bit on irc (needs a clearer commit msg since 32 bytes is the limit and a comment explaining what's going on). -Daniel > > On Mon, Sep 24, 2012 at 10:32 AM, Paulo Zanoni <przanoni at gmail.com> wrote: > > From: Paulo Zanoni <paulo.r.zanoni at intel.com> > > > > This should never happen, but the silent "return" makes me wonder > > every time I try to debug InfoFrame bugs, so promote this to BUG() to > > make sure people will complain if we ever break this. > > > > Signed-off-by: Paulo Zanoni <paulo.r.zanoni at intel.com> > > --- > > drivers/gpu/drm/i915/intel_hdmi.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c > > index 229897f..f9fb47c 100644 > > --- a/drivers/gpu/drm/i915/intel_hdmi.c > > +++ b/drivers/gpu/drm/i915/intel_hdmi.c > > @@ -377,6 +377,7 @@ static void g4x_set_infoframes(struct drm_encoder *encoder, > > port = VIDEO_DIP_PORT_C; > > break; > > default: > > + BUG(); > > return; > > } > > > > @@ -435,6 +436,7 @@ static void ibx_set_infoframes(struct drm_encoder *encoder, > > port = VIDEO_DIP_PORT_D; > > break; > > default: > > + BUG(); > > return; > > } > > > > -- > > 1.7.10.4 > > > > _______________________________________________ > > Intel-gfx mailing list > > Intel-gfx at lists.freedesktop.org > > http://lists.freedesktop.org/mailman/listinfo/intel-gfx > > > > -- > Rodrigo Vivi > Blog: http://blog.vivi.eng.br > _______________________________________________ > Intel-gfx mailing list > Intel-gfx at lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch
