> -----Original Message----- > From: Wu, Fengguang > Sent: Thursday, September 13, 2012 11:14 AM > To: Wang, Xingchao > Cc: intel-gfx at lists.freedesktop.org; alsa-devel at alsa-project.org; > daniel.vetter at ffwll.ch; tiwai at suse.de; Zhao, Yakui; Fu, Michael > Subject: Re: [PATCH] drm/i915: HDMI - Clear Audio Enable bit for Hot Plug > unconditionally > > > u32 enable_bits = SDVO_ENABLE; > > > > - if (intel_hdmi->has_audio) > > - enable_bits |= SDVO_AUDIO_ENABLE; > > + enable_bits |= SDVO_AUDIO_ENABLE; > > The two lines can be combined: > > u32 enable_bits = SDVO_ENABLE | SDVO_AUDIO_ENABLE; Looks better, I send out V2 patch for Daniel. -- Xingchao
