On Thu, 6 Sep 2012 13:54:08 -0700 Ben Widawsky <ben at bwidawsk.net> wrote: > Provide a standardized sysfs interface for setting min, and max > frequencies. The code which reads the limits were lifted from the > debugfs files. As a brief explanation, the limits are similar to the CPU > p-states. We have 3 states: > > RP0 - ie. max frequency > RP1 - ie. "local min" frequency I'd say "preferred min" or "vmin" here instead. > RPn - seriously lowest frequency > > Initially Daniel asked me to clamp the writes to supported values, but > in conforming to the way the cpufreq drivers seem to work, instead > return -EINVAL (noticed by Jesse in discussion). > > The values can be used by userspace wishing to control the limits of the > GPU (see the CC list for people who care). Can you add this and any other i915 bits that are missing to the sysfs documentation under Documentation/? Thanks for moving to -EINVAL, it makes a lot more sense to me. -- Jesse Barnes, Intel Open Source Technology Center
