On Wed, Sep 5, 2012 at 8:14 PM, Jesse Barnes <jbarnes at virtuousgeek.org> wrote: > An ugly intermediate step... also did you check whether moving the > crtc->x/y assignment up is safe? We're passing it around, but some > places might check for crtc->x/y looking for old values (or did that > already change in the previous patch... too many patches). Yeah, I've hunted around in the codebase and found nothing for these. I also wanted to give crtc->mode the same treatment, but that is definitely used all over the place. Obviously double-checking this by the reviewer would be great ;-) Wrt this being an ugly intermediate step: The disable/modeset stuff was scary enough that I wanted to do that in discrete patches, hence this slightly ugly prep step. -Daniel -- Daniel Vetter daniel.vetter at ffwll.ch - +41 (0) 79 365 57 48 - http://blog.ffwll.ch
