On Wed, Sep 5, 2012 at 6:26 PM, Jesse Barnes <jbarnes at virtuousgeek.org> wrote: > On Sun, 19 Aug 2012 21:12:48 +0200 > Daniel Vetter <daniel.vetter at ffwll.ch> wrote: > >> Atm we can only check the connector state after a dpms call - while >> doing modeset with the copy&pasted crtc helper code things are too >> ill-defined for proper checking. But the idea is very much to call >> this check from the modeset code, too. >> >> v2: Fix dpms check and don't presume that if the hw isn't on that it >> must not be linked up with an encoder (it could simply be switched off >> with the dpms state). > > Nice. Only comment is that we may want to call it assert_state() to > match our other assertions. But no biggie. All the other assertions (mostly) check whether we get the modeset _sequence_ right, i.e. whether A is in the right state once we get around to frob B. This stuff here mostly checks whether our own state tracking somewhat resembles the actual hw state after the entire dance is completed. This is especially important to give the fastboot stuff better coverage: We use the same functions to read the intial modeset state from the as we use to check the modeset state after any state changes. So I think the concepts are sufficiently different to get away with different names ;-) -Daniel -- Daniel Vetter daniel.vetter at ffwll.ch - +41 (0) 79 365 57 48 - http://blog.ffwll.ch
