On Sun, 19 Aug 2012 21:12:53 +0200 Daniel Vetter <daniel.vetter at ffwll.ch> wrote: > At the end this won't be of much use to us, but meanwhile just extract > it to get a better overview of what exactly set_config does. > > Signed-Off-by: Daniel Vetter <daniel.vetter at ffwll.ch> > --- > drivers/gpu/drm/i915/intel_display.c | 127 +++++++++++++++++++++-------------- > 1 file changed, 76 insertions(+), 51 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c > index 63bcc37..fc4902a 100644 > --- a/drivers/gpu/drm/i915/intel_display.c > +++ b/drivers/gpu/drm/i915/intel_display.c > @@ -6733,11 +6733,82 @@ static void intel_set_config_free(struct intel_set_config *config) > kfree(config); > } FWIW these last two would be handy in the helper code, but since we're abandoning it I guess we can just let it rot. :) Reviewed-by: Jesse Barnes <jbarnes at virtuousgeek.org> -- Jesse Barnes, Intel Open Source Technology Center