[PATCH] drm/i915: be less verbose about inability to provide vendor backlight

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 25, 2012 at 09:51:06AM +0100, Chris Wilson wrote:
> On Thu, 25 Oct 2012 10:57:38 +0300, Jani Nikula <jani.nikula at intel.com> wrote:
> > commit 28dcc2d60cb570d9f549c329b2f51400553412a1
> > Author: Jani Nikula <jani.nikula at intel.com>
> > Date:   Mon Sep 3 16:25:12 2012 +0300
> > 
> >     drm/i915: do not expose a dysfunctional backlight interface to userspace
> > 
> > prevents backlight interface creation if the BIOS has not set the backlight
> > PWM CTL registers that contain the max PWM value. It's apparently normal on
> > those machines, so demote the message about it to debug level.
> > 
> > Reported-by: Orion Poplawski <orion at cora.nwra.com>
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=56330
> > Signed-off-by: Jani Nikula <jani.nikula at intel.com>
> 
> We may want to create an explicit bug/task to track the missing
> initialisation as a reminder as well.

I suspect we'll get them automatically when people complain about
non-working backlights. Like they already do for non-working edp without
the bios' help. Till that happens, I'm choosing blissfull ignorance ;-)

> Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>

Picked up for -fixes, thanks for the patch.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch


[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux