[PATCH 08/18] drm/i915: check TRANSCODER_EDP on intel_modeset_setup_hw_state

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 24, 2012 at 1:38 PM, Daniel Vetter <daniel at ffwll.ch> wrote:
> On Tue, Oct 23, 2012 at 06:29:58PM -0200, Paulo Zanoni wrote:
>> From: Paulo Zanoni <paulo.r.zanoni at intel.com>
>>
>> We need to check if any of the pipes is using TRANSCODER_EDP.
>>
>> Signed-off-by: Paulo Zanoni <paulo.r.zanoni at intel.com>
>
> One thing that irks me is that you add new state readout code here, but
> don't call the same code in the modeset_check_state code

Isn't what the previous patch introduce? (look at the
intel_ddi_get_hw_state() hunk in the patch 07/18 of the series).
AFAICS we're are already checking if the pipe returned by the encoder
is what we think it is.

-- 
Damien


[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux