On Tue, Oct 23, 2012 at 07:25:35AM -0700, Jesse Barnes wrote: > On Tue, 23 Oct 2012 10:53:07 +0100 > Chris Wilson <chris at chris-wilson.co.uk> wrote: > > > On Sat, 20 Oct 2012 21:13:05 +0200, Daniel Vetter <daniel.vetter at ffwll.ch> wrote: > > > ... like the comment says. No idea whether this has any effect, but > > > I guess it's better to not lie to the display by acking a test request > > > and never following through with it. > > > > > > Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch> > > > > Ha, if I've learnt anything by now making the code consistent with the > > comments inside intel_dp.c only leads to pain... > > > > Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk> > > > > But really this needs an ack by Jesse: > > > > commit a60f0e38d72a5e24085d6e7e27a4cadc20ae268a > > Author: Jesse Barnes <jbarnes at virtuousgeek.org> > > Date: Thu Oct 20 15:09:17 2011 -0700 > > > > drm/i915: add DP test request handling > > > > DPCD 1.1+ adds some automated test infrastructure support. Add support > > for reading the IRQ source and jumping to a test handling routine if > > needed. Subsequent patches will handle particular tests; this patch > > just ACKs any requested tests by default. > > -Chris > > > > I don't think it matters; the only thing that should be looking at this > is the DP test equipment. I haven't seen any sinks generate test > requests yet (but then I don't have many...). > > So 'meh' on this patch from me. Applied, thanks for the review. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch
