On Tue, 2012-10-23 at 12:46 +0200, Daniel Vetter wrote: > On Tue, Oct 23, 2012 at 12:07:52PM +0300, Imre Deak wrote: > > Signed-off-by: Imre Deak <imre.deak at intel.com> > > --- > > tests/flip_test.c | 58 ++++++++++++++++++++++++++++++++++++++++++++--------- > > 1 file changed, 48 insertions(+), 10 deletions(-) > > > > In v2: > > - Wait for the seq that just completed (current_seq) not last_seq - 1. > > - Do an equality check for ts and seq instead of >=. The previous issue > > didn't let us do this before. > > - Simplify the condition when we do an "expired sequence" check by only > > using the last flip event as a reference. > > Patch style comment: I prefer the changelog above the --- so that it's > included in the commit message. Safe obviously when the new patch has > abosulutely nothing to do with previous versions. Ok, noted. So far I thought the only benefit of the history here is to make the reviewer's life easier, but I agree it may be useful even later to understand the context. --Imre
