Hi Michal, > > @@ -75,6 +75,8 @@ i915-$(CONFIG_PERF_EVENTS) += i915_pmu.o > > # "Graphics Technology" (aka we talk to the gpu) > > obj-y += gt/ > > gt-y += \ > > + gt/debugfs_gt.o \ > > + gt/debugfs_pm.o \ > > hm, maybe this should be: > gt/intel_gt_debugfs.o > and > gt/intel_pm_debugfs.o this was actually the name I wanted to give it originally, but meantime I also wanted to have the debugfs files alphabetically sorted in sequence, like the selftest_* files (I can imagine in the future having more debugfs files). Maybe intel_debugfs_gt.c/intel_debugfs_pm.c would be a good compromise? > > @@ -0,0 +1,22 @@ > > +/* SPDX-License-Identifier: MIT */ > > in .c SPDX shall start with // I agree this is the "official" way of doing it, and I also read some discussions about it in this mailing list. But however I do it, I know someone won't like it. I checked the style in this directory and tried to keep it conform to the "gt way". If no one will reject it because of it, I will send a v5 with '//'. Thanks for the review, Andi _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
