✗ Fi.CI.CHECKPATCH: warning for drm/i915: debugfs device parameters

[Patchwork <patchwork@xxxxxxxxxxxxxxxxxxxxxx>]

== Series Details ==

Series: drm/i915: debugfs device parameters
URL   : https://patchwork.freedesktop.org/series/70502/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
9f8f858a3391 drm/i915/params: add i915 parameters to debugfs
-:66: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#66: 
new file mode 100644

-:298: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'x' may be better as '(x)' to avoid precedence issues
#298: FILE: drivers/gpu/drm/i915/i915_debugfs_params.c:228:
+#define REGISTER(T, x, unused, mode, ...) _i915_param_create_file(dir, #x, #T, mode, &params->x);

-:298: WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon
#298: FILE: drivers/gpu/drm/i915/i915_debugfs_params.c:228:
+#define REGISTER(T, x, unused, mode, ...) _i915_param_create_file(dir, #x, #T, mode, &params->x);

total: 0 errors, 2 warnings, 1 checks, 372 lines checked
7db14ea24487 drm/i915/params: support bool values for int and uint params
-:23: WARNING:LINE_SPACING: Missing a blank line after declarations
#23: FILE: drivers/gpu/drm/i915/i915_debugfs_params.c:38:
+		bool b;
+		ret = kstrtobool_from_user(ubuf, len, &b);

-:37: WARNING:LINE_SPACING: Missing a blank line after declarations
#37: FILE: drivers/gpu/drm/i915/i915_debugfs_params.c:90:
+		bool b;
+		ret = kstrtobool_from_user(ubuf, len, &b);

total: 0 errors, 2 warnings, 0 checks, 26 lines checked

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx