Hi all, this is some LVDS/eDP panel refactoring and cleanup based on Chris Wilson's earlier work and ideas last year [1]. I left out eDP lid notifier based on Jesse's comments [2]; more of Jesse's old review is at [3]. The main high level difference to Chris' patches is that intel_panel and the cached EDID are placed in intel_connector rather than anywhere else. This is because Daniel hinted that we might want to do some more generic EDID caching (indeed, why keep reading the EDID if the display has not been unplugged?). With the EDID and intel_panel in intel_connector, we can add functions to query EDID and modes with transparent caching and fallback to fixed mode when EDID is not available. BR, Jani. [1] http://cgit.freedesktop.org/~ickle/linux-2.6/log/?h=panel-refactor [2] http://lists.freedesktop.org/archives/intel-gfx/2011-April/010419.html [3] http://lists.freedesktop.org/archives/intel-gfx/2011-April/thread.html#10401 Jani Nikula (10): drm/i915/lvds: Rename intel_lvds to intel_lvds_encoder drm/i915/lvds: Introduce intel_lvds_connector drm/i915/lvds: Move the acpi_lid_notifier from drm_i915_private to the connector drm/i915: Backlight setup requires connector so pass it as parameter drm/i915/lvds: Move some connector specific info across from the encoder drm/i915/dp: Initialize eDP fixed mode in intel_dp_init drm/i915: Create generic intel_panel for LVDS and eDP drm/i915: Move the fixed mode to intel_panel drm/i915: Do not free the passed EDID in intel_connector_update_modes() drm/i915: Move cached EDID to intel_connector drivers/gpu/drm/i915/i915_drv.h | 4 - drivers/gpu/drm/i915/intel_crt.c | 6 +- drivers/gpu/drm/i915/intel_dp.c | 144 +++++++++++++----------- drivers/gpu/drm/i915/intel_drv.h | 20 +++- drivers/gpu/drm/i915/intel_lvds.c | 211 ++++++++++++++++++++---------------- drivers/gpu/drm/i915/intel_modes.c | 7 +- drivers/gpu/drm/i915/intel_panel.c | 32 ++++-- 7 files changed, 241 insertions(+), 183 deletions(-) -- 1.7.9.5