On Sat, Oct 13, 2012 at 02:29:31PM +0200, Egbert Eich wrote: > For TV and LVDS encoders intel_sdvo_set_input_timings_for_mode() > is called to pass a mode to the sdvo chip and retrieve a dtd > containing information needed to calculate the adjusted_mode which > is done by intel_sdvo_get_dtd_from_mode(). > To set this adjusted_mode as input mode for the sdvo chip, a dtd is > recalculated using intel_sdvo_get_mode_from_dtd(). During this round > trip the sdvo_flags contained in the dtd obtained from the hardware > are lost. > Since these flags cannot be ignored in all cases this patch preserves > and restores them. > > This regression has been introduced in > > commit 6651819b4b4fc3caa6964c5d825eb4bb996f3905 > Author: Daniel Vetter <daniel.vetter at ffwll.ch> > Date: Sun Apr 1 19:16:18 2012 +0200 > > drm/i915: handle input/output sdvo timings separately in mode_set > > Signed-off-by: Egbert Eich <eich at suse.de> Long term we need to decently improve our adjusted_mode handling and stop shoveling random state into random structures. Short-term this looks good enough. Thanks for the patch, applied. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch
