Hi all, This is a start at stopping to use the register save/restore stuff with kms enabled. Imo we've had too many bugs in the resume code because no one seems to care about this code and check whether it still makes sense for new platforms. Or to check whether a bugfix to a reg write sequence also needs to be applied there. Or whether restoring some random register is a good idea at all. So I've started to audit all the register write/restores and check whether our normal setup code could possible rely on this. If I haven't found anything, I've braketed the respective block with a if (!KMS) check. I probably need a few more days of utter boredom to work through it all. Comments, flames and review highly welcome. Cheers, Daniel Daniel Vetter (6): drm/i915/crt: don't set HOTPLUG bits on !PCH drm/i915/crt: explicitly set up HOTPLUG_BITS on resume drm/i915: don't save/restor ADPA for kms drm/i915: don't save/restore DP regs for kms drm/i915: don't save/restore irq regs for kms drm/i915: don't save/restore HWS_PGA reg for kms drivers/gpu/drm/i915/i915_drv.c | 1 - drivers/gpu/drm/i915/i915_suspend.c | 154 +++++++++++++++++++---------------- drivers/gpu/drm/i915/intel_crt.c | 32 ++++---- drivers/gpu/drm/i915/intel_display.c | 2 + 4 files changed, 103 insertions(+), 86 deletions(-) -- 1.7.11.2
