== Series Details == Series: drm/i915: customize DPCD brightness control for specific panel (rev2) URL : https://patchwork.freedesktop.org/series/67595/ State : warning == Summary == $ dim checkpatch origin/drm-tip ebafaef17574 drm/i915: customize DPCD brightness control for specific panel -:35: WARNING:LONG_LINE: line over 100 characters #35: FILE: drivers/gpu/drm/drm_dp_helper.c:1272: + { OUI(0xba, 0x41, 0x59), DEVICE_ID_ANY, false, BIT(DP_DPCD_QUIRK_CUSTOMIZE_BRIGHTNESS_CONTROL) }, -:52: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (16, 32) #52: FILE: drivers/gpu/drm/drm_dp_helper.c:1306: + if (quirk->quirks == DP_DPCD_QUIRK_CUSTOMIZE_BRIGHTNESS_CONTROL && [...] + continue; -:72: WARNING:LONG_LINE: line over 100 characters #72: FILE: drivers/gpu/drm/drm_dp_helper.c:1344: + ret = drm_dp_dpcd_read(aux, DP_EDP_TCON_CAPABILITY_BYTE0, tcon_cap, sizeof(tcon_cap)); -:90: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #90: FILE: drivers/gpu/drm/i915/display/intel_dp.c:7095: + if (drm_dp_has_quirk(&intel_dp->desc, + DP_DPCD_QUIRK_CUSTOMIZE_BRIGHTNESS_CONTROL)) { -:112: CHECK:PREFER_KERNEL_TYPES: Prefer kernel type 'u8' over 'uint8_t' #112: FILE: drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c:33: + uint8_t read_val[2] = { 0x0 }; -:117: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #117: FILE: drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c:38: + DRM_DEBUG_KMS("Failed to read DPCD register %x\n", + DP_EDP_BRIGHTNESS_NITS); -:130: CHECK:PREFER_KERNEL_TYPES: Prefer kernel type 'u8' over 'uint8_t' #130: FILE: drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c:51: + uint8_t new_vals[4]; -:145: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #145: FILE: drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c:66: +static void intel_dp_aux_enable_customize_backlight(const struct intel_crtc_state *crtc_state, + const struct drm_connector_state *conn_state) -:149: CHECK:PREFER_KERNEL_TYPES: Prefer kernel type 'u8' over 'uint8_t' #149: FILE: drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c:70: + uint8_t read_val[4], i; -:150: CHECK:PREFER_KERNEL_TYPES: Prefer kernel type 'u8' over 'uint8_t' #150: FILE: drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c:71: + uint8_t write_val[8] = {0x00, 0x00, 0xF0, 0x01, 0x90, 0x01, 0x00, 0x00}; -:152: WARNING:LONG_LINE: line over 100 characters #152: FILE: drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c:73: + if (drm_dp_dpcd_write(&intel_dp->aux, DP_EDP_PANEL_LUMINANCE_OVERRIDE, write_val, sizeof(write_val)) < 0) -:157: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #157: FILE: drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c:78: + DRM_DEBUG_KMS("Failed to write %x\n", + DP_EDP_BRIGHTNESS_OPTIMIZATION); -:167: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #167: FILE: drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c:88: + DRM_DEBUG_KMS("Failed to read %x\n", + DP_EDP_GETSET_CTRL_PARAMS); -:171: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #171: FILE: drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c:92: + DRM_DEBUG_KMS("Failed to write %x\n", + DP_EDP_GETSET_CTRL_PARAMS); -:175: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #175: FILE: drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c:96: + DRM_DEBUG_KMS("Failed to read %x\n", + DP_EDP_GETSET_CTRL_PARAMS); -:177: WARNING:LONG_LINE: line over 100 characters #177: FILE: drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c:98: + if (drm_dp_dpcd_read(&intel_dp->aux, DP_EDP_CONTENT_LUMINANCE, &read_val, sizeof(read_val)) < 0) -:179: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #179: FILE: drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c:100: + DRM_DEBUG_KMS("Failed to read %x\n", + DP_EDP_CONTENT_LUMINANCE); -:182: WARNING:LONG_LINE: line over 100 characters #182: FILE: drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c:103: + if (drm_dp_dpcd_write(&intel_dp->aux, DP_EDP_CONTENT_LUMINANCE, read_val, sizeof(read_val)) < 0) -:184: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #184: FILE: drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c:105: + DRM_DEBUG_KMS("Failed to write %x\n", + DP_EDP_CONTENT_LUMINANCE); -:188: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #188: FILE: drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c:109: + DRM_DEBUG_KMS("Failed to read %x\n", + DP_EDP_GETSET_CTRL_PARAMS); -:206: WARNING:LONG_LINE: line over 100 characters #206: FILE: drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c:127: +static void intel_dp_aux_disable_customize_backlight(const struct drm_connector_state *old_conn_state) -:210: WARNING:RETURN_VOID: void function return statements are not generally useful #210: FILE: drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c:131: + return; +} -:220: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #220: FILE: drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c:334: +static int intel_dp_aux_setup_customize_backlight(struct intel_connector *connector, + enum pipe pipe) -:253: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #253: FILE: drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c:397: + if (drm_dp_has_quirk(&intel_dp->desc, + DP_DPCD_QUIRK_CUSTOMIZE_BRIGHTNESS_CONTROL)) { total: 0 errors, 8 warnings, 16 checks, 254 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
