[PATCH 04/17] drm/i915: track is_dual_link in intel_lvds

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 27, 2012 at 06:58:51PM -0200, Paulo Zanoni wrote:
> <bikeshedding>
> Here we could try to add some debug message telling whether we found
> dual-link LVDS or not. I don't know how useful it would be, but I
> added it to test your patches on my machine (I was not really sure
> whether it supported dual-link LVDS or not).
> 
> Something like:
> + if (lvds_encoder->is_dual_link)
> +        DRM_DEBUG_KMS("Dual link LVDS found\n");
> </bikeshedding>
> 
> Still, the patch looks correct, so with or without the debug message:
> Reviewed-by: Paulo Zanoni <paulo.r.zanoni at intel.com>

Excellent idea, I've slightly generalized the output so that it tells
whether single or dual link has been detected.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch


[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux