On Tue, Nov 27, 2012 at 06:38:18PM -0200, Paulo Zanoni wrote: > Hi > > 2012/11/26 Daniel Vetter <daniel.vetter at ffwll.ch>: > > Currently we have two encoder specific bits in the common mode_set > > functions: > > - lvds pin pair enabling > > - dp m/n setting and computation > > > > Now the lvds stuff needs to happen before the pll is enabled. Since > > that is done in the crtc_mode_set functions, we need to add a new > > callback to be able to move them to the encoder code (where they > > belong). The dp m/n stuff is a giant mess anyway (since it also > > confuses itself with the fdi link m/n handling), so that needs to be > > handled separately. > > > > I think that we can move the pll enabling down quite a bit, which > > might allow us to eventually merge encoder->pre_enable with this new > > pre_pll_enable callback. But for now this will allow us to clean > > things up a bit. > > > > Note that vlv doesn't support lvds, hence we don't need to change > > anything in there. > > My only worry is that in the future we might use the pre_pll_enable > callback for some non-LVDS encoder, and then we'll forget about > calling this on VLV. I really hope that we've cleaned things up by then and this pre_pll_enable hook is gone again. So merged as-is. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch
