[PATCH 4/4] drm/i915: only call intel_prepare_ddi if HAS_DDI

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 23 Nov 2012 15:30:40 -0200, Paulo Zanoni <przanoni at gmail.com> wrote:
> From: Paulo Zanoni <paulo.r.zanoni at intel.com>
> 
> In other words, move the check from inside the function to outside it.

Don't agree with this last step. You can make the function tidier with
an early return, but it is paramount that the high level sequence inside
intel_modeset_init_hw() be clear and comprehendable.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux