On Mon, Nov 19, 2012 at 08:42:59AM -0800, Eric Anholt wrote: > Chris Wilson <chris at chris-wilson.co.uk> writes: > > > The intention of checking obj->gtt_offset!=0 is to verify that the > > target object was listed in the execbuffer and had been bound into the > > GTT. This is guarranteed by the earlier rearrangement to split the > > execbuffer operation into reserve and relocation phases and then > > verified by the check that the target handle had been processed during > > the reservation phase. > > > > However, the actual checking of obj->gtt_offset==0 is bogus as we can > > indeed reference an object at offset 0. For instance, the framebuffer > > installed by the BIOS often resides at offset 0 - causing EINVAL as we > > legimately try to render using the stolen fb. > > We've never triggered this check in practice, as far as I know, so I'm > happy to see it go. > > Reviewed-by: Eric Anholt <eric at anholt.net> Queued for -next, thanks for the patch. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch
