On Fri, Nov 16, 2012 at 7:28 PM, Paulo Zanoni <przanoni at gmail.com> wrote:
> Hi
>
> 2012/11/5 Daniel Vetter <daniel.vetter at ffwll.ch>:
>> Especially getting rid of all things lvds is ... great!
>>
>> Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch>
>> ---
>> intel_crtc_update_cursor(crtc, true);
>>
>> /* determine panel color depth */
>> dither = intel_choose_pipe_bpp_dither(crtc, fb, &intel_crtc->bpp, mode);
>
> Patch doesn't apply because on my tree (based on drm-intel-nightly)
> this line uses "adjusted_mode" instead of "mode". I have no idea if
> this is a problem or not, but maybe it rings a bell for you.
Yeah, that's just Jani's dp 6bpc fix getting a bit in the way. Will fix up.
> For completeness of your patch, you may also want to remove the following lines:
>
> Check obsoleted by your "check soulmates" patch:
>
> /* We are not sure yet this won't happen. */
> WARN(!HAS_PCH_LPT(dev), "Unexpected PCH type %d\n",
> INTEL_PCH_TYPE(dev));
Will remove.
> The only ibx/cpt check remaining:
>
> if (HAS_PCH_IBX(dev) || HAS_PCH_CPT(dev)) {
> /* For non-DP output, clear any trans DP clock
> recovery
> * setting.*/
> I915_WRITE(TRANSDATA_M1(pipe), 0);
> I915_WRITE(TRANSDATA_N1(pipe), 0);
> I915_WRITE(TRANSDPLINK_M1(pipe), 0);
> I915_WRITE(TRANSDPLINK_N1(pipe), 0);
This will die in one of the dp patches.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
