On Tue, Nov 13, 2012 at 04:39:43PM +0200, Jani Nikula wrote:
> On Sat, 10 Nov 2012, Chris Wilson <chris at chris-wilson.co.uk> wrote:
> > @@ -583,7 +583,10 @@ void intel_gmbus_force_bit(struct i2c_adapter *adapter, bool force_bit)
> > {
> > struct intel_gmbus *bus = to_intel_gmbus(adapter);
> >
> > - bus->force_bit = force_bit;
> > + bus->force_bit += force_bit ? 1 : -1;
> > + DRM_DEBUG_KMS("%sabling bit-banging on %s. force bit now %d\n",
> > + force_bit ? "dis" : "en", adapter->name,
> > + bus->force_bit);
>
> Reading a dmesg from Chris, I noticed force_bit ? "dis" : "en" is
> backwards.
Thanks for spotting this, rebase out, it never happened.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
