On Sat, Nov 10, 2012 at 03:58:21PM +0000, Chris Wilson wrote: > This fixes a regression for SDVO from > > commit fbfcc4f3a0cf8bbde87646b74241faa8e37426bf > Author: Jani Nikula <jani.nikula at intel.com> > Date: Mon Oct 22 16:12:18 2012 +0300 > > drm/i915/sdvo: restore i2c adapter config on intel_sdvo_init() failures > > As SDVOB and SDVOC are multiplexed on the same pin, if a chipset does > not have the second SDVO encoder, it will then remove the force-bit > setting on the common i2c adapter during teardown. All subsequent > attempts of trying to use GMBUS with SDVOB then fail. > > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk> > Cc: Jani Nikula <jani.nikula at intel.com> > Cc: Mika Kuoppala <mika.kuoppala at intel.com> Fixes annoyingly loud WARN spam on my i915G w/ sdvo. Oh, how wonderful it would be when our QA would run more than 5 machines and be able to report such regression timely and with a bisect result ... /me keeps on dreaming Thanks a lot for tracking this down, patch merged to dinq. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch
