Re: [PATCH 33/39] drm/i915/perf: add a parameter to control the size of OA buffer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 22/08/2019 12:43, Joonas Lahtinen wrote:
Quoting Lucas De Marchi (2019-08-16 11:04:57)
From: Lionel Landwerlin <lionel.g.landwerlin@xxxxxxxxx>

The way our hardware is designed doesn't seem to let us use the
MI_RECORD_PERF_COUNT command without setting up a circular buffer.

In the case where the user didn't request OA reports to be available
through the i915 perf stream, we can set the OA buffer to the minimum
size to avoid consuming memory which won't be used by the driver.

Cc: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx>
Cc: Matthew Auld <matthew.auld@xxxxxxxxx>
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@xxxxxxxxx>
Signed-off-by: Lucas De Marchi <lucas.demarchi@xxxxxxxxx>
---
  drivers/gpu/drm/i915/i915_perf.c | 98 +++++++++++++++++++++-----------
  drivers/gpu/drm/i915/i915_reg.h  |  2 +
  include/uapi/drm/i915_drm.h      |  7 +++
Any patch touching i915_drm.h should have a link to the corresponding
userspace series.

Regards, Joonas

Might be worth dropping this patch from the series then.

I don't think we have anything public or any coming userspace release making use of this.


Cheers,


-Lionel

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux