I've been trying to identify MMIO ranges to clearly define what belongs to display_uncore to do a check on access, but there are lots of exceptions and differences across gens (with a few more coming with TGL), so I don't think that's a viable way. The alternative option implemented here is to differentiate the register by type, which should ensure we never mix them up, but at the cost of a more complex transition. Thoughts? I'm very open to (and I actually hope for) better ideas. Cc: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> Cc: Jani Nikula <jani.nikula@xxxxxxxxx> Cc: Lucas De Marchi <lucas.demarchi@xxxxxxxxx> Daniele Ceraolo Spurio (3): drm/i915: split out uncore_mmio_debug drm/i915: introduce display_uncore drm/i915: convert a couple of registers to _DE_MMIO .../gpu/drm/i915/display/intel_display_reg.h | 66 ++++++++++++ drivers/gpu/drm/i915/display/intel_hdmi.c | 32 +++--- drivers/gpu/drm/i915/i915_debugfs.c | 2 +- drivers/gpu/drm/i915/i915_drv.c | 20 +++- drivers/gpu/drm/i915/i915_drv.h | 32 ++++++ drivers/gpu/drm/i915/i915_reg.h | 44 -------- drivers/gpu/drm/i915/intel_uncore.c | 100 +++++++++++++----- drivers/gpu/drm/i915/intel_uncore.h | 18 ++-- 8 files changed, 215 insertions(+), 99 deletions(-) create mode 100644 drivers/gpu/drm/i915/display/intel_display_reg.h -- 2.22.0 _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
