On Thu, 1 Nov 2012 15:18:04 +0100 Daniel Vetter <daniel at ffwll.ch> wrote: > On Thu, Nov 1, 2012 at 3:09 PM, Ville Syrj?l? > <ville.syrjala at linux.intel.com> wrote: > >> Userspace doesn't use this today at all even in the panning case? > > > > If it does, then the user is going to be upset when nothing happens. > > Only the x/y offsets are effective with the current code. > > > >> I > >> know it worked at one point at least, but that may have been back in > >> the UMS days... > > > > Before my time. > > Afaik the fb->offsets have been added to support planar formats with > all planes smashed into the same buffer object (where the fourcc alone > doesn't specify anything about inter-plane offsets). We don't support > planar buffers, so enforcing an offset of 0 is imo totally ok. Ok yeah was confusing it with the x/y offsets. -- Jesse Barnes, Intel Open Source Technology Center
