On Thu, May 24, 2012 at 1:22 PM, Jesse Barnes <jbarnes at virtuousgeek.org>wrote:
> static ssize_t
> +i915_min_freq_read(struct file *filp,
> + char __user *ubuf,
> + size_t max,
> + loff_t *ppos)
> +{
> + struct drm_device *dev = filp->private_data;
> + drm_i915_private_t *dev_priv = dev->dev_private;
> + char buf[80];
>
<bikeshed>
I think 20 characters, as in min_freq_write, would be enough here.
</bikeshed>
> + /*
> + * Turbo will still be enabled, but won't go above the set value.
> + */
> + dev_priv->min_delay = val / 50;
>
I guess the comment here is meant to say that turbo won't go below the set
value.
But other than that,
Reviewed-by: Eugeni Dodonov <eugeni.dodonov at intel.com>
--
Eugeni Dodonov
<http://eugeni.dodonov.net/>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20120524/fa79aae6/attachment.html>
